WIP Add warning for mobile users attempting coding tutorials#620
Open
terichadbourne wants to merge 4 commits intomainfrom
Open
WIP Add warning for mobile users attempting coding tutorials#620terichadbourne wants to merge 4 commits intomainfrom
terichadbourne wants to merge 4 commits intomainfrom
Conversation
terichadbourne
changed the title
Member
Author
|
Working on a banner to use on the landing page of coding tutorials and on the non-coding lessons that are sometimes included in coding tutorials. How do you feel about this concept, @zebateira? If we included messaging about both the JavaScript and the device, we could use it across the board on these to also help warn folks who don't know how to code. We could also cut up the text conditionally so that it only mentions the device if our media query suggests your device won't work. on landing page of coding tutorial
on non-coding lesson w/in coding tutorial |
Contributor
|
Looking good 👍 Some concerns:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147 by warning users with low res devices that they won't be able to complete coding challenges without a keyboard.
Currently this catches you on any lesson page within a tutorial (excluding landing page and resources) that contains coding challenges, even if the current lesson happens to be a quick text-based intro to upcoming content. Propose changing so the modal only appears on the coding lessons themselves and adding a separate non-modal banner to the landing page and any preliminary non-coding lessons so you know to expect the negative experience before getting started but can still see the page.